fix: removes Extra keyword from volumeMounts and Volumes for the data… #3592
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3588) fix: removes Extra keyword from volumeMounts and Volumes for the data plane
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.0 #3592 +/- ##
===============================================
+ Coverage 86.80% 86.83% +0.03%
===============================================
Files 127 127
Lines 15087 15087
Branches 62 62
===============================================
+ Hits 13096 13101 +5
+ Misses 1840 1836 -4
+ Partials 151 150 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ciarams87
approved these changes
Jul 4, 2025
|
Is there anything blocking this PR going in? I am assuming at this point I have handed off my PR and this will be released int he next helm chart. |
|
@vazkarvishal It's already been merged into main, this is just to cherrypick into our release branch for our next release. |
bjee19
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… plane
Cherrypick of #3588
Proposed changes
Fixing 3585
Problem: Incorrect Helm Schema for the data plane volume mounts.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Deployed it on my cluster to see if failure of schema validation does not occur anymore
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
fix: removes Extra keyword from volumeMounts and Volumes for the data…