Skip to content

fix: removes Extra keyword from volumeMounts and Volumes for the data… #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jul 4, 2025

… plane

Cherrypick of #3588

Proposed changes

Fixing 3585

Problem: Incorrect Helm Schema for the data plane volume mounts.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Deployed it on my cluster to see if failure of schema validation does not occur anymore

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

fix: removes Extra keyword from volumeMounts and Volumes for the data…

fix: removes Extra keyword from volumeMounts and Volumes for the data…

#3588)

fix: removes Extra keyword from volumeMounts and Volumes for the data plane
@sjberman sjberman requested a review from a team as a code owner July 4, 2025 01:08
@github-actions github-actions bot added the helm-chart Relates to helm chart label Jul 4, 2025
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (51cf307) to head (39f77a2).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.0    #3592      +/-   ##
===============================================
+ Coverage        86.80%   86.83%   +0.03%     
===============================================
  Files              127      127              
  Lines            15087    15087              
  Branches            62       62              
===============================================
+ Hits             13096    13101       +5     
+ Misses            1840     1836       -4     
+ Partials           151      150       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vazkarvishal
Copy link
Contributor

vazkarvishal commented Jul 7, 2025

Is there anything blocking this PR going in? I am assuming at this point I have handed off my PR and this will be released int he next helm chart.

@sjberman
Copy link
Collaborator Author

sjberman commented Jul 7, 2025

@vazkarvishal It's already been merged into main, this is just to cherrypick into our release branch for our next release.

@sjberman sjberman enabled auto-merge (squash) July 7, 2025 16:01
@sjberman sjberman merged commit 271ca22 into release-2.0 Jul 7, 2025
76 of 78 checks passed
@sjberman sjberman deleted the helm/volumes branch July 7, 2025 17:39
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants